Closed
Conversation
Paste documentation examples to `README.md` in a loop instead of duplicating the same lines for all of the engines. Also, changed signature of the `serpapi.Client` to accept three parameters instead of a dict. This mentally distinguishes arguments allowed to the client from the `Client#search()` method. Also, fixed `make all` execution by prepending `python -m` to Python commands. Co-authored-by: Dmitriy Zub <dmitriy@serpapi.com>
Contributor
|
I integrate 2/3 changes in the master. Approved
Rejected
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We with @dimitryzub reviewed #1 and applied some fixes:
Paste documentation examples to
README.mdin a loop instead of duplicating the same lines for all of the engines.Changed signature of the
serpapi.Clientto accept three parameters instead of a dict. This mentally distinguishes arguments allowed to the client from theClient#search()method.Fixed
make allexecution by prependingpython -mto Python commands.This PR is WIP. We will copy examples from serpapi/google-search-results-python#36 to this PR.